Data sampler: Allow selecting 100% of data, shuffle it#3727
Merged
thocevar merged 1 commit intobiolab:masterfrom Apr 12, 2019
Merged
Data sampler: Allow selecting 100% of data, shuffle it#3727thocevar merged 1 commit intobiolab:masterfrom
thocevar merged 1 commit intobiolab:masterfrom
Conversation
Member
|
Removed requirement 4 from the comment, as I do not remember anymore what the intended use case was. |
Codecov Report
@@ Coverage Diff @@
## master #3727 +/- ##
==========================================
+ Coverage 84.53% 84.54% +<.01%
==========================================
Files 373 373
Lines 68472 68490 +18
==========================================
+ Hits 57886 57902 +16
- Misses 10586 10588 +2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2035.
Description of changes
#2035 required:
I've done them all, but I didn't have a good use case in 4. @ajdapretnar, in an already agitated state because of certain issues around #3722, told me in no uncertain terms to remove it. I'm married for 17 years, so I know better than to complain. On the contrary, I must say that I didn't like that text either, so I was very happy to remove it.
Documentation still explains that choosing the entire data set shuffles it, which, I must say, should suffice.
(Joke aside, it indeed does.)
Includes